search

uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

lagoon labels pods in openshift with `services` label #24

Closed Schnitzel closed 3 years ago

Schnitzel commented 3 years ago

build and pushed this as amazeeio/lagoon-builddeploy:v0.1.7-rc1

shreddedbacon commented 3 years ago

Are we eventually going to transition to using lagoon.sh/X for labels, and phase out the generic labelling like service?

Schnitzel commented 3 years ago

@shreddedbacon yes we did already for k8s deployments, for openshift deployments I'm not sure, as my hope with openshift 4 is anyway that we can use the k8s deployment system and don't need the openshift deployment way at all anymore :)

shreddedbacon commented 3 years ago

I think this will be fine to merge, but where else do we use this label selector?

If possible, being able to change other things or run a script that will update existing labels to the new ones may be better?

Schnitzel commented 3 years ago

@shreddedbacon I though about this too, but we would need to change the labels of all running pods which means we have to change also the labels of the deploymentconfigs which will cause a redeployment. So I don't think that's really feasible.

Schnitzel commented 3 years ago

oh and it's actually used by the deploymentconfig to know which pods it's controlling: https://github.com/amazeeio/lagoon/blob/master/images/oc-build-deploy-dind/openshift-templates/nginx/deployment.yml#L62

so changing this would be even harder as the label is used by openshift to know which pods it started, etc.

shreddedbacon commented 3 years ago

Bugger. Will merge then