uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

feat: add SHORT_ROUTER_URL to the build environment #37

Closed smlx closed 3 years ago

smlx commented 3 years ago

The domain name of this URL is (almost) guaranteed to be less than 63 chars in length, so it can be used as a CN in certificate requests.

The use of base32 is an attempt to increase the entropy of the 8 character string over simple hex encoding, in order to reduce the likelihood of collisions. Not sure how necessary it is, really.

This is part of a fix for https://github.com/amazeeio/lagoon/issues/2310

shreddedbacon commented 3 years ago

LGTM