uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

Add missing routes and log link to message #42

Closed shreddedbacon closed 3 years ago

shreddedbacon commented 3 years ago

When converting the old kubernetesbuilddeploymonitor into the controller, a step was missed that crafts the slack message and adds the routes and log link. Slack is the only notification service I can see that does this differently (see notes below)

This adds those missing features to the message.

Ideally, the entire notification service in Lagoon should be re-written so this Message block isn't required and the entire block from the controller is omitted.

The notification service in Lagoon should craft the information it needs from the other Meta fields to make for a more consistent messaging across multiple notification services.