uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift

5 stars 1 forks source link

Routes links doubled in message after build #47

Closed vincenzodnp closed 1 year ago

vincenzodnp commented 3 years ago

Describe the bug

The route(s)' links in the message after a build, are doubled.

To Reproduce

Check if in the configmap you have both LAGOON_ROUTE and LAGOON_ROUTES with value and run a build

Expected behavior

Just a single link per route

Check https://github.com/amazeeio/lagoon-kbd/pull/42/files

shreddedbacon commented 3 years ago

I think this is because LAGOON_ROUTES contains all the routes, including LAGOON_ROUTE. So need to do some check that only uses one or the other, should be fairly easy.

shreddedbacon commented 1 year ago

Closing, as I believe this has been resolved on the Lagoon-core side in logs2notifications