search

uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

Openshift Task creation fails with `an empty namespace may not be set during creation` #67

Closed Schnitzel closed 3 years ago

Schnitzel commented 3 years ago

I merged #25 and released it under amazeeio/lagoon-builddeploy:v0.1.14-pr25, but we have now an issue when creating a task via the controller on an openshift:

2021-06-28T20:19:02.575Z    INFO    controllers.LagoonTask  Checking task pod for: lagoon-task-10692-ngpw1d {"lagoontask": "drupal-example-1-master/lagoon-task-10692-ngpw1d"}
2021-06-28T20:19:02.587Z    INFO    controllers.LagoonTask  Creating task pod for: lagoon-task-10692-ngpw1d {"lagoontask": "drupal-example-1-master/lagoon-task-10692-ngpw1d"}
2021-06-28T20:19:02.587Z    INFO    controllers.LagoonTask  Unable to create task pod for project drupal-example-1, environment master: an empty namespace may not be set during creation   {"lagoontask": "drupal-example-1-master/lagoon-task-10692-ngpw1d"}
2021-06-28T20:19:02.587Z    DEBUG   controller-runtime.controller   Successfully Reconciled {"controller": "lagoontask", "request": "drupal-example-1-master/lagoon-task-10692-ngpw1d"}
shreddedbacon commented 3 years ago

Fixed in #68 and updated ch1 to use amazeeio/lagoon-builddeploy:v0.1.14-pr68 and verified.

Need to write tests for tasks into the controller tests to capture this.

Schnitzel commented 3 years ago

confirmed! epic thanks @shreddedbacon