search

uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

duplicated restore object name #72

Closed vincenzodnp closed 3 years ago

vincenzodnp commented 3 years ago

The kubernetes restore object's name is created by using the first 7 chars of the backup_ip. Ie: if the backup id is 8888888xxxxxxxxxxxxxxxxx the restore object name will be restore-8888888. If the restore for any reason fails, the restore object is not deleted and this prevents a new restore to be created (because object already exists). Probably the best to randomize or add a random string to the restore object to prevent failures.

shreddedbacon commented 3 years ago

This is actually handled in Lagoon itself here https://github.com/uselagoon/lagoon/blob/b4bca1afaf8a9a2c99dfdc10a5e6e16c69bcc613/node-packages/commons/src/tasks.ts#L910

I'll close this and raise an issue in Lagoon