uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

Don't use camelcase for flags #77

Closed shreddedbacon closed 3 years ago

shreddedbacon commented 3 years ago

I just realised the backup retention/default flags use camelCase and not kebab-case like other flags. I should have picked this up before I merged it but here we are.

    flag.StringVar(&backupDefaultSchedule, "backupDefaultSchedule", "M H(22-2) * * *",
        "The default backup schedule for all projects on this cluster.")
    flag.IntVar(&backupDefaultMonthlyRetention, "backupDefaultMonthlyRetention", 1,
        "The number of monthly backups k8up should retain after a prune operation.")
    flag.IntVar(&backupDefaultWeeklyRetention, "backupDefaultWeeklyRetention", 6,
        "The number of weekly backups k8up should retain after a prune operation.")
    flag.IntVar(&backupDefaultDailyRetention, "backupDefaultDailyRetention", 7,
        "The number of daily backups k8up should retain after a prune operation.")
    flag.IntVar(&backupDefaultHourlyRetention, "backupDefaultHourlyRetention", 0,
        "The number of hourly backups k8up should retain after a prune operation.")