search

usememos / memos

An open-source, lightweight note-taking solution. The pain-less way to create your meaningful notes. Your Notes, Your Way.
https://usememos.com
MIT License
34.17k stars 2.47k forks source link

Excuse me, direct connection mp3 and mp4 with external link inserted cannot be played #2143

Closed langvs closed 1 year ago

langvs commented 1 year ago

Describe the bug

Excuse me, direct connection mp3 and mp4 with external link inserted cannot be played, how can I solve this problem.

Steps to reproduce

Use Add Media as normal QQ图片20230816024153

Screenshots or additional context

QQ图片20230816023328

QQ图片20230816023438 QQ图片20230816023403

Zeng1998 commented 1 year ago

Does your memo site run with HTTPS ?

langvs commented 1 year ago

Using nginx anti proxy and enabling SSL certificate. However, the direct link address is a list program for onedrive! This direct link address works well in other programs~

Zeng1998 commented 1 year ago

It seems that the html tags audio and video do not support the file types of audio/* and video/*. That should be fixed by specifying the specific type.

Zeng1998 commented 1 year ago

I think an auto detection for file types would be great.

boojack commented 1 year ago

Fixed in https://github.com/usememos/memos/commit/73980e9644dd3978753328912f7c454a3f45cd67