search

usememos / memos

An open-source, lightweight note-taking solution. The pain-less way to create your meaningful notes. Your Notes, Your Way.
https://usememos.com
MIT License
34.16k stars 2.47k forks source link

urlPrefix disappear in s3 storage option？ #3436

Closed ixxmu closed 5 months ago

ixxmu commented 5 months ago

Describe the bug

urlPrefix disappear in s3 storage option？ It showed in previous version S3 options

Steps to reproduce

just check the s3 storage system

The version of Memos you're using

Version: v0.22.0

Screenshots or additional context

No response

Somme4096 commented 5 months ago

Yes, it did disappear in my environment too. I will research on it.

enshui commented 5 months ago

well , 0.21 it is shown ,but latest disappear

Somme4096 commented 5 months ago

Removed by this commit: https://github.com/usememos/memos/commit/320963098f7a1ce76a9e493aede078b560f0ea33

The reason for the removal of this feature is described in the v0.22.0 release notes:

S3 Storage related resources will be using pre-signed url and supports synchronized deletion.

And link to original author's message: https://github.com/usememos/memos/issues/3403#issuecomment-2119466204

We will use presigned urls to provide more secure links. It is recommended to use an S3 API-compatible object store such as cloudflare R2.