search

usememos / memos

An open-source, lightweight note-taking solution. The pain-less way to create your meaningful notes. Your Notes, Your Way.
https://usememos.com
MIT License
34.06k stars 2.47k forks source link

disallow_password_login option is gone #3719

Closed petrm closed 3 months ago

petrm commented 3 months ago

Describe the bug

Latest release v0.22.3 moved the the option to disable registration to the configuration via environment variable. Same pull request also removed the possibility to disallow password loging and only leave SSO on. Please bring back SSO-only login.

Steps to reproduce

N/A option is not available anymore

The version of Memos you're using.

v0.22.3

Screenshots or additional context

No response

MFYDev commented 3 months ago

Met the same issue here

tanpro260196 commented 3 months ago

Please bring this back, I don't want to potentially expose my host account to normal user.

Westwall98 commented 3 months ago

Need disallow_password_login. Please bring it back

EriTang commented 3 months ago

Need disallow_password_login. Please bring it back

boojack commented 3 months ago

Updated with https://github.com/usememos/memos/commit/8bf7cdfd31037734ea91198b8d11fa3775a5faac

Jayspek commented 3 months ago

When I start it with the --password-auth false, it still says "password-auth: true" in the startup information, and I am still able to log in with a password. Seems to be broken?

boojack commented 3 months ago

my_application -debug=false -another_boolean_param=boolean_value

@Jayspek Refer to https://stackoverflow.com/a/27411724

Jayspek commented 3 months ago

My bad, thanks for the pointer!