usememos / memos

An open source, lightweight note-taking service. Easily capture and share your great thoughts.
https://usememos.com
MIT License
30.31k stars 2.27k forks source link

/u/user note with an image is wrongly resized in 0.22.5 box #3887

Closed mariushosting closed 2 weeks ago

mariushosting commented 2 weeks ago

Describe the bug

when someone visit someone /u/user profile page the notes with an image is very well fit in the box on version 0.22.4 but on version 0.22.5 the notes with an image is not well fit anymore in the box.

Steps to reproduce

visit someone profile /u/user on version 0.22.4 then visit someone profile /u/user on version 0.22.5 You will notice if the user have an image in the note this one is not fit anymore in the box.

The version of Memos you're using.

0.22.5

Screenshots or additional context

No response

mariushosting commented 2 weeks ago

Screenshot 2024-09-06 07 24 28 Screenshot 2024-09-06 07 24 53

Issues-translate-bot commented 2 weeks ago

Issue is not in English. It has been translated automatically.


Screenshot 2024-09-06 07 24 28 Screenshot 2024-09-06 07 24 53

RoccoSmit commented 2 weeks ago

From version 22.5 a thumbnail version of the image is displayed in the feed. This thumbnail should be 700px wide if the image is more than 700px wide. The feed should also be just over 700px wide so the thumbnail will fit exactly.

can you confirm the image width of your version 22.5 displayed image as well as the feed width

mariushosting commented 2 weeks ago

From version 22.5 a thumbnail version of the image is displayed in the feed. This thumbnail should be 700px wide if the image is more than 700px wide. The feed should also be just over 700px wide so the thumbnail will fit exactly.

can you confirm the image width of your version 22.5 displayed image as well as the feed width

https://blog.mariushosting.com/u/mariushosting

Version 22.4 fit perfect. But 22.5 no.

RoccoSmit commented 2 weeks ago

Did you revert back to 22.4? Can't replicate the issue when following your link

mariushosting commented 2 weeks ago

Did you revert back to 22.4? Can't replicate the issue when following your link

Yes I reverted to 22.4

I have update now with 22.5 please check.

RoccoSmit commented 2 weeks ago

Are you setting a custom feed column width in your settings? In the additional css

mariushosting commented 2 weeks ago

Are you setting a custom feed column width in your settings? In the additional css

Absolutely no.

RoccoSmit commented 2 weeks ago

Interesting, ok. Something is changing your ui because you don't have the search or tags menus and you have a share feature instead. Can you share some context around this?

mariushosting commented 2 weeks ago

Interesting, ok. Something is changing your ui because you don't have the search or tags menus and you have a share feature instead. Can you share some context around this?

I think you are confusing two different pages. One is this with the tags: https://blog.mariushosting.com/explore The other is this "user" https://blog.mariushosting.com/u/mariushosting

RoccoSmit commented 2 weeks ago

You are right. I was unaware of the user specific page

mariushosting commented 2 weeks ago

You are right. I was unaware of the user specific page

I will reverse back to 22.4 since the 22.5 break image fit in the user page.

RoccoSmit commented 2 weeks ago

Proposed solutions:

  1. Leave it as is / upscale thumbnail from 700px to 1080px with custom added css
  2. Make the user memos page use the same width as the home and explore page for its feed so that the thumbnails fit at 700px
  3. Add a prop to the memoview component to indicate if a thumbnail should be used so that thumbnails can be deactivated
  4. Add a prop to the memoview component to set the size of the thumbnail allowing for different size thumbnails

@boojack can you give some guidance here please. I'm happy to work on this

boojack commented 2 weeks ago

@RoccoSmit Please check out for https://github.com/usememos/memos/commit/4790e84b984a5076a19b01a5c0ef6c503ef7c103. It's better to use ratio instead of max width.

RoccoSmit commented 2 weeks ago

Thanks, I left a comment on the commit