search

useplunk / plunk

The Open-Source Email Platform
https://www.useplunk.com
GNU Affero General Public License v3.0
2.95k stars 136 forks source link

Domain Verification Records incorrect for subdomains #71

Closed driaug closed 1 week ago

driaug commented 2 months ago

If you verify a subdomain in the dashboard, the records required aren't correctly displayed and only show the root domain.

For example the records for verifying mail.useplunk.com, will be shown as:

While they should be

The file in the dashboard that hosts this code is: https://github.com/useplunk/plunk/blob/main/packages/dashboard/src/pages/settings/identity.tsx

The project that contains the email that is currently waiting for verification is in activeProject.email

nklmantey commented 1 week ago

@driaug just confirming, is this issue still open? would love to try it out

driaug commented 1 week ago

This one is still open!

nklmantey commented 1 week ago

great, working on it right now :)

nklmantey commented 1 week ago

opened a pr to fix this https://github.com/useplunk/plunk/pull/116

driaug commented 1 week ago

Thank you for your contribution!

Closed by #116