user-cont / colin

Tool to check generic rules/best-practices for containers/images/dockerfiles.
GNU General Public License v3.0
52 stars 27 forks source link

unable to use colin via make install #199

Closed jscotka closed 6 years ago

jscotka commented 6 years ago

command sudo make install but there is no colin binary and no colin dir in sitepackages: ls: cannot access '/usr/lib/python3.6/site-packages/colin*': No such file or directory

after calling sudo pip2 install . colin binary is there and also /usr/lib/python2.7/site-packages/colin , but causes traceback:

Traceback (most recent call last):
  File "/usr/bin/colin", line 11, in <module>
    load_entry_point('colin==0.2.1', 'console_scripts', 'colin')()
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 476, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2700, in load_entry_point
    return ep.load()
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2318, in load
    return self.resolve()
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2324, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/lib/python2.7/site-packages/colin/cli/colin.py", line 25, in <module>
    from colin.utils.cmd_tools import get_version_msg_from_the_cmd, is_rpm_installed, \
ImportError: No module named utils.cmd_tools

and command sudo pip3 install . will not istall anything to site-packages:

 ls -d /usr/lib/python*/site-packages/colin*
ls: cannot access '/usr/lib/python*/site-packages/colin*': No such file or directory
lachmanfrantisek commented 6 years ago

This mix multiple problems:

TomasTomecek commented 6 years ago

The question is: do we actually support sudo make install installation? I don't see it mentioned in README.

@jscotka please use a method which is mentioned in README or suggest how we can improve existing situation.

Edit: @lachmanfrantisek we want to support as few things as possible. Our primary use case is to run colin in a container and that's our focus. Since we have it in Fedora, we also support a case when people install it from official Fedora repos, we also publish to PyPI so that's obvious as well.

Unfortunately we are not able to debug funky installations done by our internal make targets, or installing straight from git -- we can't be sure what's on the target system or even what the target system is.