Open TomasTomecek opened 6 years ago
Maybe we should either error out if there is : in image name; or parse it and use and error out in case tag param is set and there is tag in the name.
I think this approach is perfect.
Is the tag being mentioned as name:tag
a standard thing for all container technologies, or is just a docker thing? If it is a standard thing, then it could implemented in the apidefs
, otherwise implementing it only in the DockerBackend
would be better.
Good (and hopefully well tested) parsing we have in the colin. The plan was to move that code to conu.
@SkullTech AFAIK all the container runtimes utilize images names and tags, so we can totally put ti to apidefs
Gentlemen, thanks for feedback, I updated the original post with TODO for this one.
Maybe we should either error out if there is
:
in image name; or parse it and use and error out in case tag param is set and there is tag in the name.But anyway, when I set tag in the image name, conu should not eat it.
Suggestions are welcome.
Edit: yeah, and the image instance is completely unusable:
Edit 2: TODO:
:
in image name: parse it:
in image name and tag param is also set, raise an exception