Use `oc cluster up` in CI

user-cont / conu

conu - python API for your containers

http://conu.readthedocs.io/en/latest/

MIT License

165 stars 33 forks source link

Use `oc cluster up` in CI #280

Closed rpitonak closed 5 years ago

rpitonak commented 6 years ago

Ready for review.

rpitonak commented 5 years ago

@jpopelka Thank you for review, should be fixed now.

rpitonak commented 5 years ago

[test]

rpitonak commented 5 years ago

@jpopelka can you take a look? Basically I removed time.sleep(30) from all k8s tests and implemented new method that checks if there are secrets created in namespace.

Also there is now Probe when we call oc-start-build.

jpopelka commented 5 years ago

Tests are passing and Tomas's objections seem to be resolved, thanks ! I'd like to override Tomas's NACK and merge but I don't seem to have enough privilege to do that.

EDIT: One have to click on 'Dismiss' and actually write some resolution into the text box.