user-cont / conu

conu - python API for your containers
http://conu.readthedocs.io/en/latest/
MIT License
165 stars 33 forks source link

req.sh: clarify deps, remove make; remove pytest from dfile.tests #291

Closed TomasTomecek closed 6 years ago

TomasTomecek commented 6 years ago

related https://github.com/user-cont/conu/pull/290

jscotka commented 6 years ago

Thanks a lot. situation with various requiremetns is very unclear.

could be improved, for example, docker files for tests contain explicit using pip/pip3, in vagrant, there were used way with make, in make file there is just pip install . and not pip and pip3 install together and also that situation with requirements.in and requirements.txt what is sometimes (I don't know exactly when) updated by this .in file

jpopelka commented 6 years ago

How is this supposed to fix anything when enum34 is already in requirements.txt ?

TomasTomecek commented 6 years ago

2 things:

  1. ideally, req.sh would contain all the rpm deps and other logic needed to run conu (what Honza needs)
  2. we prefer RPMs over upstream content from PyPI: we can easily patch RPMs, not the content on PyPI
jpopelka commented 6 years ago

Ok, I personally prefer not to duplicate things, other than in cases documented here.

But if you want it, then you're still missing python[2|3]-six, python[2|3]-docker and python[2|3]-kubernetes.

TomasTomecek commented 6 years ago

okay, that makes sense, let's fix the doc string then

jpopelka commented 6 years ago

And also I think that installing the rpms is quite useless since there are exact versions in requirements.txt so the pip install will uninstall the rpm versions and install different ones.

TomasTomecek commented 6 years ago

jeeeesh, cut me some slack, dude

Okay, we actually do pip install --user, so nothing gets uninstalled.

TomasTomecek commented 6 years ago

PTAL