Creation of pod from template using k8s backend

user-cont / conu

conu - python API for your containers

http://conu.readthedocs.io/en/latest/

MIT License

165 stars 33 forks source link

Closed rpitonak closed 5 years ago

rpitonak commented 5 years ago

Functionality is implemented in the constructor of Pod class, not in run_in_pod method because we want to be able to create pod without DockerBackend.
not sure if this is the best way how to handle metadata, but add them all as parameters or even create PodMetadata with all of them, seem like overkill to me.

Related to #277.

TomasTomecek commented 5 years ago

I agree with you that PodMetadata sounds like an overkill. We can close #277 after this is merged.

Sorry that I broke CI, this PR should fix it: #336

rpitonak commented 5 years ago

[test]

TomasTomecek commented 5 years ago

[test]

TomasTomecek commented 5 years ago

LGTM, test failures are unrelated

TomasTomecek commented 5 years ago

I guess we can merge, WDYT?

rpitonak commented 5 years ago

Sure, feel free to merge, if there are no other comments.