Remove python2 support - Githubissues

user-cont / conu

conu - python API for your containers

http://conu.readthedocs.io/en/latest/

MIT License

165 stars 33 forks source link

Remove python2 support #357

Closed phracek closed 5 years ago

phracek commented 5 years ago

Signed-off-by: Petr "Stone" Hracek phracek@redhat.com

This pull request removes python2 support. I have already checked issues:

make rpm
make test-in-container
make srpm

TomasTomecek commented 5 years ago

I rescheduled the CI build:

requests.exceptions.ChunkedEncodingError: ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))

seems like a flake

phracek commented 5 years ago

All tests passed but the script fails on source-to-image

TomasTomecek commented 5 years ago

FML, how could the CI pass when we changed the spec back then -_-

error: line 42: Unknown tag: Recommends:     source-to-image

So we need to do make srpm in a Fedora container. I vote to remove srpm target from the ci target and let packit handle this in future.

phracek commented 5 years ago

I vote as well.