six usage is redundant - Githubissues

user-cont / conu

conu - python API for your containers

http://conu.readthedocs.io/en/latest/

MIT License

164 stars 33 forks source link

six usage is redundant #390

Open pgajdos opened 1 year ago

pgajdos commented 1 year ago

As you declare that this package is 3.6+, could you please consider drop of dependency on six please?

lachmanfrantisek commented 1 year ago

Hi @pgajdos !

Yes, that's a good suggestion. This will also require a bit of code cleanup as well...

Do you think you can take a look at that and get rid of it? https://github.com/user-cont/conu/search?q=six&type=code

I'll take a look otherwise...

pgajdos commented 1 year ago

Nazdar!

https://build.opensuse.org/package/view_file/devel:languages:python/python-conu/python-conu-no-six.patch

This works with 'not (integration or test_get_port_mappings or selinux or ownership)' pytest run, detailed build log can be found here:

https://build.opensuse.org/package/live_build_log/home:pgajdos:python/python-conu/openSUSE_Tumbleweed/x86_64

I am not 100% sure this is complete, though.

Petr

jpopelka commented 1 year ago

Nazdar :)

I could apply your patch, but it'd be better if you created a pull request with the change so that

we can discuss the code there
you'll be recorded as an author in the history of the repo

pgajdos commented 1 year ago

I think it is clear I am unsure I can do an upstream class submission, but here you are. Sure we can discuss, but I do not aspire to be author of this change if not necessary ;).