user-cont / release-bot-deployment

MIT License
2 stars 5 forks source link

service port #11

Closed jpopelka closed 4 years ago

jpopelka commented 4 years ago

I've been trying to deploy release bot (built from https://github.com/user-cont/release-bot/pull/237) in my local 'oc cluster' and I'm not able to access it. Trying to POST something to http://release-bot-myproject.127.0.0.1.nip.io/webhook-handler/ still returns 503 Service Unavailable.

Release bot seems to run on 8080, while the openshift/service.yml says 8443. Any ideas what I might be missing?

marusinm commented 4 years ago

Since you are using oc cluster commnad I guess you have OpenShift 3.x. I am using OpenShift Online 4.1 and deployment is running without problems. When I look into YML file of running service which you mentioned I see this:

ports:
    - name: prod-release-bot
      protocol: TCP
      port: 443
      targetPort: 8080

So all communication via 443 should be forwarded to 8080 inner port of the pod if I understand correctly.

If you'll try OpenShift Online please build the image and push to docker hub. I was using marusinm/release-bot image instead of usercont/release-bot which is now in the Makefile.

jpopelka commented 4 years ago

I guess you have OpenShift 3.x.

yes

When I look into YML file of running service which you mentioned I see this: targetPort: 8080

Then you must have edited it or something because the service.yml says 8443.

please build the image and push to docker hub

will do once I make 'container-things' work in F31 to which I've just upgraded

marusinm commented 4 years ago

Then you must have edited it or something because the service.yml says 8443

Yes, you are right I missed it somehow. Sorry, I opened PR #13