search

userapp-io / userapp-angular

AngularJS module that adds user authentication to your app with UserApp.
https://userapp.io
MIT License
233 stars 84 forks source link

html5Mode breaks social login. #4

Closed garbados closed 10 years ago

garbados commented 10 years ago

https://github.com/userapp-io/userapp-angular/blob/master/angularjs.userapp.js#L784 sets the default oauth callback to use #/ routing, which breaks if your app doesn't use hash fragment routing, for example if you set html5Mode(true).

timothyej commented 10 years ago

I'm looking at this right now, just trying to figure out how to determine the mode (html5 or not, and special hashbang).

timothyej commented 10 years ago

This bug is now fixed in the working branch (https://raw.githubusercontent.com/userapp-io/userapp-angular/master/angularjs.userapp.js).

Please give it a try before I release it as a new version. Thanks for noticing this bug!

garbados commented 10 years ago

Wahoo! Thanks for jumping on it so quick! I'll give it a whirl momentarily :D

garbados commented 10 years ago

Yep! Works! Thanks!