search

userback / widget-js

MIT License
4 stars 3 forks source link

Change double loading from error to warning. #27

Closed josheverett closed 2 years ago

josheverett commented 2 years ago

Hot reloads during local development trigger this error, which is very disruptive. As this is benign, it ought to be a warning rather than an error.

Shard commented 2 years ago

Hey @josheverett,

Thanks for making a PR for this! Makes sense to me after thinking about it and having it return the already loaded Userback object is a much better API for that situation.

Ill have a look over what happened with the e2e tests today.

For the docs action, we just need to run yarn docs from the root and commit that so the docs for GitHub pages is in sync 👍🏻 .

Shard commented 2 years ago

Looks like there is an issue with how the CI is setup for tokens when run outside the org as it wants you to provide a UB_TOKEN in your own repo instead of using our token.

For this time I created a 2nd PR #28 with your changes and ill be looking to fixup the gh actions issue in #22.

Thanks again for your contributions!