search

userback / widget-js

MIT License
4 stars 3 forks source link

Adds exports to package.json #46

Closed ekwoka closed 1 year ago

ekwoka commented 1 year ago

solves #45

The new standard for resolving different exports is with the export key. https://nodejs.org/api/packages.html#package-entry-points

Some environments will require these to work properly.

Shard commented 1 year ago

Hi @ekwoka,

Thanks for pointing this out. I didn't have a good understanding of the new fields thinking the existing fields should be adequate but I also had been trying to figure out what was the cause of nested imports swapping between cjs/mjs.

I'm going to try and fix the CI for external PR's, do a little testing and we will be looking to merge this very quickly!

Cheers.

Shard commented 1 year ago

@ekwoka, If you want to try re-pulling develop I think the e2e tests should run correctly now. Cheers.