userback / widget-js

MIT License
4 stars 3 forks source link

Delays initialization on React #51

Closed ekwoka closed 1 year ago

ekwoka commented 1 year ago

Solves a portion of #21

This PR:

I couldn't get tests to work at all locally (not entirely sure the steps needed to even run them as the readme seemed incomplete) so those will need to be checked, and possibly additional tests added for this.

Shard commented 1 year ago

Hi @ekwoka,

Sorry for the delay on getting this PR moving. I remember reviewing and testing the e2e locally earlier, then trying to get the e2e working for external contributors and getting distracted by life (as always 😄 ).

I'm just going to merge it into develop now and make sure its working fine before I look to cut a new release for this 🎉

Cheers again for the contribution 🥇