search

userdive / agent.js

:woman_technologist: Official USERDIVE module for webpage analytics
https://developers.userdive.com/
GNU General Public License v3.0
7 stars 6 forks source link

[breaking changes] Dispatch only tap event, exclude touchmove #931

Closed 9renpoto closed 5 years ago

9renpoto commented 5 years ago

TL;DR

Connect to #914

Check this pr.

How to check

Check list

9renpoto commented 5 years ago

Oops, It became an unexpected rebase 🤔

codecov[bot] commented 5 years ago

Codecov Report

Merging #931 into devel/3 will decrease coverage by 0.27%. The diff coverage is 75%.

@@             Coverage Diff             @@
##           devel/3     #931      +/-   ##
===========================================
- Coverage    91.74%   91.46%   -0.28%     
===========================================
  Files           25       25              
  Lines          630      633       +3     
  Branches       112      112              
===========================================
+ Hits           578      579       +1     
- Misses          28       30       +2     
  Partials        24       24
Impacted Files Coverage Δ
packages/agent/src/events/scroll.ts 76.92% <100%> (ø) :arrow_up:
packages/agent/src/events/mousemove.ts 83.33% <100%> (ø) :arrow_up:
packages/agent/src/events/click.ts 83.33% <100%> (ø) :arrow_up:
packages/agent/src/events.ts 96.96% <100%> (ø) :arrow_up:
packages/agent/src/events/touch.ts 48% <50%> (-2%) :arrow_down: