search

userfrosting / UserFrosting

Modern PHP user login and management framework
https://www.userfrosting.com
Other
1.63k stars 367 forks source link

StrykeSlammerII v420 patch 1 #1212

Closed StrykeSlammerII closed 2 years ago

StrykeSlammerII commented 2 years ago

At one point I completely tore down my DB and tried rebuilding via migrations, with my own sprinkles in place. Somehow Bakery insisted on running the v420/AddingForeignKeys migration before most of the v400 migrations, so of course it errored and Bakery choked. I've added here the relevant dependencies, and Bakery was able to correctly run all my migrations with these changes.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1212 (f7ec266) into hotfix (774bc45) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             hotfix    #1212   +/-   ##
=========================================
  Coverage     68.45%   68.45%           
  Complexity     1987     1987           
=========================================
  Files           169      169           
  Lines          6685     6685           
=========================================
  Hits           4576     4576           
  Misses         2109     2109
Impacted Files Coverage Δ
...src/Database/Migrations/v420/AddingForeignKeys.php 100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

lcharette commented 2 years ago

I agree it make way more sense to add those dependencies.