userfrosting / UserFrosting

Modern PHP user login and management framework
https://www.userfrosting.com
Other
1.63k stars 369 forks source link

Refactor cache system #838

Open lcharette opened 6 years ago

lcharette commented 6 years ago

The current UF cache package is overly complicated for nothing and inconsistent. For example, we create a new RedisStore, but have to call getInstance() to actually get a RedisStore.

Instead of creating singleton and fake app to create the RedisManager, it should probably be easier to directly implement our own CacheManager instead so we don't have to deal with Laravel app instance. Instead of defining RedisManager in $app it could probably be done in CacheManager directly.


TODO

lcharette commented 6 years ago

Also while the cache service provides one cache store at a time, it could be useful allow for multiple cache store to be used.

Incidentally, the clear-cache Bakery command could also accept more options.

lcharette commented 6 years ago

...and it would require a way to globally disable cache (aka enable the arraystore)