userfrosting / learn

Documentation and guide for UserFrosting
https://learn.userfrosting.com
MIT License
14 stars 41 forks source link

Lando local hosting support #102

Closed Silic0nS0ldier closed 3 years ago

Silic0nS0ldier commented 3 years ago

Also fixes some Twig HTML escaping issues that may have been introduced by dependency updates within Grav.

Lando automatically acquires Grav behind the scenes, and is pinned to a specific version (1.7.12 currently).

Silic0nS0ldier commented 3 years ago

Ordinarily I'd agree to have local install be the "default", but as the process is more tedious (historically I have avoided working on the docs because of this) I'm of the mind that this is an exception to the rule.

More generally regarding the README.md for the other branches, it would probably be worthwhile cutting out the bulk of their content (and directing users to the website branch) so that branch specific docs act more as a billboard for what this branch is. (e.g. "4.0 Docs", "4.1 Docs", "4.x Docs", "Latest Docs", and "vNext Docs" or something along those lines). Currently its not immediately clear.

lcharette commented 3 years ago

Difference is I don't recommend actually working on the docs in the website branch because of how submodules works and can get messed up. It should only be used as "read only" IMO. That's why focus should be on the latest branch.