Fix dockerfile.

[azhard4int]

PR Type

enhancement, configuration changes

---

Description

• Updated the Dockerfile to use Node.js version 20-alpine and added npm global installation of pnpm.
• Cleaned npm cache and removed existing node_modules in the Dockerfile.
• Added TypeScript as a workspace dependency in the Dockerfile.
• Updated paths for Nginx configuration and build output in the Dockerfile.
• Updated Dockerfile path in docker-compose.yaml.
• Added node_modules to .dockerignore to prevent unnecessary files from being included in the Docker context.

---

Changes walkthrough 📝

	Relevant files
Configuration changes	.dockerignore Add node_modules to .dockerignore                                                .dockerignore - Added `node_modules` to `.dockerignore`. +2/-0      docker-compose.yaml Update Dockerfile path in docker-compose.yaml                        docker-compose.yaml - Updated Dockerfile path in `docker-compose.yaml`. +1/-1
Enhancement	Dockerfile Update Dockerfile with new Node.js version and configurations packages/javascript-sdk/docker/Dockerfile Updated Node.js version to 20-alpine. Added npm global installation of pnpm. Cleaned npm cache and removed existing node_modules. Added TypeScript as a workspace dependency. Updated paths for Nginx configuration and build output. +12/-14

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions[bot]]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🏅 Score: 85

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Bug The Dockerfile uses `npm cache clean --force` and `rm -rf node_modules` which might not be necessary if the build context is properly managed. Performance Issue Using `RUN ls -R` and `RUN ls -al` for debugging purposes can increase the build time and the size of the build logs unnecessarily.

Code feedback:

---

relevant file	packages/javascript-sdk/docker/Dockerfile
suggestion	Consider removing the `RUN ls -R` and `RUN ls -al` commands unless they are essential for the build process. These commands can clutter the build log and do not contribute to the actual build process. [important]
relevant line	RUN ls -R

---

relevant file	packages/javascript-sdk/docker/Dockerfile
suggestion	Consider using a multi-stage build to separate the build environment from the production environment. This can help reduce the final image size by excluding development dependencies and build artifacts that are not needed in production. [important]
relevant line	FROM node:20-alpine AS builder

---

relevant file	packages/javascript-sdk/docker/Dockerfile
suggestion	Replace `npm cache clean --force && rm -rf node_modules` with a more efficient cleanup strategy or ensure that these steps are necessary. If node_modules are not copied into the Docker image, this step might be redundant. [medium]
relevant line	RUN npm cache clean --force && \

---

[github-actions[bot]]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Best practice	Use a specific version of the base image to ensure consistent builds ___ **Consider using a specific version of node instead of node:20-alpine to ensure consistent, predictable builds.** [packages/javascript-sdk/docker/Dockerfile [1]](https://github.com/usermaven/usermaven-js/pull/117/files#diff-7a5f39cf5bcb819885a0b5b04234de54a0201b2149e76ad9bf4584839d6cba4eR1-R1) ```diff -FROM node:20-alpine AS builder +FROM node:20.0.0-alpine AS builder ``` Suggestion importance[1-10]: 8 Why: Using a specific version of the base image enhances build consistency and predictability, which is crucial for avoiding unexpected issues due to changes in the base image.	8
	Lock down the version of pnpm to enhance build reproducibility ___ **Replace npm install -g pnpm with npm install -g pnpm@specific_version to lock down the version of pnpm for more reliable and reproducible builds.** [packages/javascript-sdk/docker/Dockerfile [3]](https://github.com/usermaven/usermaven-js/pull/117/files#diff-7a5f39cf5bcb819885a0b5b04234de54a0201b2149e76ad9bf4584839d6cba4eR3-R3) ```diff -RUN npm install -g pnpm +RUN npm install -g pnpm@6.14.0 ``` Suggestion importance[1-10]: 8 Why: Specifying a version for `pnpm` ensures that the build process is reproducible and not affected by future changes in `pnpm`, which is important for maintaining a stable build environment.	8
	Refine the COPY command to avoid including unwanted files ___ **Ensure that the COPY . . command does not inadvertently include unwanted files by adding a .dockerignore file or refining the copy source path.** [packages/javascript-sdk/docker/Dockerfile [5]](https://github.com/usermaven/usermaven-js/pull/117/files#diff-7a5f39cf5bcb819885a0b5b04234de54a0201b2149e76ad9bf4584839d6cba4eR5-R5) ```diff -COPY . . +COPY packages/javascript-sdk/ . ``` Suggestion importance[1-10]: 7 Why: The suggestion to refine the `COPY` command is valid as it helps prevent unnecessary files from being included in the build context, which can lead to larger image sizes and potential security risks.	7
Maintainability	Remove unnecessary commands to clean up the build log ___ **Remove the RUN ls -R command as it may clutter the build log without providing substantial benefits for the build process.** [packages/javascript-sdk/docker/Dockerfile [12]](https://github.com/usermaven/usermaven-js/pull/117/files#diff-7a5f39cf5bcb819885a0b5b04234de54a0201b2149e76ad9bf4584839d6cba4eR12-R12) ```diff -RUN ls -R +# RUN ls -R ``` Suggestion importance[1-10]: 6 Why: Removing the `RUN ls -R` command is a good practice for cleaning up the build log, making it easier to read and maintain, although it has a minor impact on the overall build process.	6