search

usernam3 / meta_commit

Enrich commit diffs with programing language insights
MIT License
8 stars 1 forks source link

not escaped argument is passed to `git notes add` #15

Open usernam3 opened 6 years ago

usernam3 commented 6 years ago

Git notes adapter should escape message before adding it to note MetaCommit::Index::Adapters::GitNotes#write_to_notes

usernam3 commented 6 years ago

Tried to use shellwords module but it writes escaped characters to note body, it is not ok. Currently the main problem is double quotes character so I just replaced them in 352b0b3734cc8a940f2133ac73720fc7728e59e7 . It works, but still needs better solution.