Closed username1565 closed 4 years ago
Yes, here is invalid decoding of pathways with cyrillic symbols,
because this pathway not utf8
-encoded, this have encoding cp1251
,
so 1251
need to write instead CP_UTF8
, in /src/windows/utf8.c
, at this line ,
to fix the support of cyrillic symbols in pathways, on Windows XP
,
and maybe, another versions of windows, where cp1251
used by default.
Maybe, this can be switched, depending from platform, or by another critery, but I don't know how to do this. So I just write 1251
there, and this is working for me.
Overview
Issue
See more tests in this issue: https://github.com/blueclouds8666/uTox_XP/issues/2
Pathways with cyrillic symbls - not working correctly.
uTox.exe
in\build
folder, after compilation.start_portable.bat
with code:uTox.exe
is portable.uTox.exe
,msvcr71.dll
, andstart_portable.bat
into the folder with cyrillic symbols in pathway.start_portable.bat
by double click.See console - errors: WinFilesys: Could not open file: blah-blah uTox: Can not open tox_save.tox to write to it.
C:\uTox\
Run againstart_portable.bat
again, wait... See\Tox
folder created, andtox_save.tox
-file andutox_save.ini
-file, inside this folder, was been created too. Restart this, and see only one error:As you can see, on step 8,
uTox.exe
can working in the folder without cyrillic symbols in pathway.If cyrillic-symbols exists in pathway, in this case,
\Tox
-folder is created, but there is no any files inside this. Maybe,path
is not valid encoded.Also, see this issue: https://github.com/uTox/uTox/issues/1393 and the history of changing
/src/windows/filesys.c
P.S.: Anoher test.
build
-folder, likebuild\блабла\
uTox.exe
start_portable.bat
Tox
-folder + (tox_save.tox
&tox_save.ini
inside) (if no cyrillic symbols in full path ofbuild
-folder).uTox.exe
,msvcr71.dll
, andstart_portable.bat
in the folder with cyrillic symbols.start_portable.bat
from this folder.Tox
-folder was been created,tox_save.ini
exists inside.tox_save.tox
loaded from previousbuild\Tox
-folder, before this folder, with cyrillic symbols. andtox_save.tox
is saved inbuild\Tox
, not inbuild\блабла\Tox
.Maybe, something need to fix for
tox_save.tox
, becausetox_save.ini
saved good inbuild\блабла\Tox
, maybe because for this file is loading correct fullpath, and this have correct encoding, but fortox_save.tox
, this full-path not loading or encoding is incorrect...