search

usernamehw / vscode-error-lens

VSCode extension that enhances display of errors and warnings.
https://marketplace.visualstudio.com/items?itemName=usernamehw.errorlens
MIT License
601 stars 32 forks source link

`errorLens.margin` has no effect #192

Closed spikespaz closed 4 months ago

spikespaz commented 12 months ago

image

  "editor.fontFamily": "'Material Design Icons', 'JetBrainsMono Nerd Font'",

  "errorLens.delayMode": "debounce",
  "errorLens.enabledDiagnosticLevels": [
    "error",
    "warning"
  ],
  "errorLens.enabledInMergeConflict": false,
  "errorLens.margin": "4ch",
  "errorLens.onSaveTimeout": 200,
  "errorLens.removeLinebreaks": false,

VS Code

Version: 1.83.1
Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc
Date: 2023-10-10T23:45:31.402Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Linux x64 6.5.9

Error Lens v3.15.0

usernamehw commented 12 months ago

Are you using errorLens.alignMessage?

spikespaz commented 12 months ago

Are you using errorLens.alignMessage?

No, the settings I have shown are all that I have used.

usernamehw commented 12 months ago

I don't know then. It doesn't reproduce with these settings.

Can you narrow it down to 1 setting or a combination of settings (minimal repro steps)?

Does it work with other units?:

"errorLens.margin": "40px",
// or
"errorLens.margin": "4em",
spikespaz commented 12 months ago

I apologize for removing the issue template. That was disrespectful, and I missed some of the minimum requirements for a useful issue.

It looks like ch is the only unit that doesn't work. This happens regardless of other settings being present. Margin is the first setting I changed for Error Lens quite some time ago. I discovered it didn't work, so other settings were irrelevant.

usernamehw commented 12 months ago

Maybe it's the "editor.fontFamily" setting? Material Design Icons doesn't make sense to use as an editor font...

spikespaz commented 12 months ago

It does make sense if you use VS Code to edit your waybar config or your terminal prompt.

I believe that the problem only happens when that font is first in fallback. Will check.