search

usernane / phMysql

PHP library for building MySQL database schema and quires.
MIT License
4 stars 2 forks source link

Update MySQLQuery.php #20

Closed ibrahimBeladi closed 4 years ago

ibrahimBeladi commented 4 years ago

YCRM

codecov-io commented 4 years ago

Codecov Report

Merging #20 into master will decrease coverage by 0.19%. The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
- Coverage     82.83%   82.64%   -0.20%     
- Complexity      949      951       +2     
============================================
  Files             6        6              
  Lines          2022     2028       +6     
============================================
+ Hits           1675     1676       +1     
- Misses          347      352       +5
Impacted Files Coverage Δ Complexity Δ
src/MySQLQuery.php 74.46% <28.57%> (-0.40%) 375.00 <0.00> (+2.00) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7e1402...1d41ce5. Read the comment docs.

usernane commented 4 years ago

I think that you should not actually pass an array as a value to insert in the database. This is not a valid fix.

ibrahimBeladi commented 4 years ago

You are using an array for departments in user settings in YCRM. How would you suggest to resolve this?