userstyles-world / userstyles.world

⭐ Website to browse and share UserCSS userstyles. A modern replacement for UserStyles.org made by the userstyles community.
https://userstyles.world
GNU Affero General Public License v3.0
324 stars 15 forks source link

Changing GitHub username creates a new user in Userstyles.World #134

Closed necodess closed 1 year ago

necodess commented 1 year ago

After changing your GitHub username and trying to log in into your Userstyle account, it creates a new user with your new GitHub username.

The real issue is: when someone creates a GitHub account with my old username, they can access to my old Userstayle account and its styles with OAuth sign in.

Old account (which is now accessed with a fake GitLab account using my old username, it was originally created with a GitHub OAuth login):

The new account which was automatically created when I tried to log in:

vednoc commented 1 year ago

I've been waiting for @Gusted to rewrite OAuth since I don't fully understand how it works. Until that happens, I'll release a patch that disables OAuth altogether. As for your accounts, I'll let you know once I resolve the issue manually.

necodess commented 1 year ago

Thanks. For these two accounts, I'll probably want to delete them later, but currently there's no "delete account" option, so my accounts are not that important for me, for now.

vednoc commented 1 year ago

OAuth has been blocking account-based functionality for a while now. Considering that I have a rudimentary idea of how it works, I'm not entirely sure how to move forward without breaking things in unexpected ways.

vednoc commented 1 year ago

This issue should be fixed now. There's still no way for you to delete your account(s), but we'll implement that pretty soon.