userver-framework / userver

Production-ready C++ Asynchronous Framework with rich functionality
https://userver.tech
Apache License 2.0
2.31k stars 268 forks source link

MAYBE BUG: `LOG` -> `USERVER_LOG` #619

Closed root-kidik closed 9 hours ago

root-kidik commented 1 month ago
[696/754] Building CXX object grpc/CMakeFiles/userver-grpc-internal.dir/src/ugrpc/server/impl/async_methods.cpp.o
In file included from /userver-develop/grpc/src/ugrpc/server/impl/async_methods.cpp:4:
/userver-develop/universal/include/userver/logging/log.hpp:256:9: warning: "LOG" redefined
  256 | #define LOG(lvl) LOG_TO(USERVER_NAMESPACE::logging::GetDefaultLogger(), (lvl))
      |         ^~~
In file included from /toolchain/usr/include/grpcpp/impl/rpc_service_method.h:29,
                 from /toolchain/usr/include/grpcpp/impl/service_type.h:25,
                 from /toolchain/usr/include/grpcpp/support/async_stream.h:28,
                 from /toolchain/usr/include/grpcpp/impl/codegen/async_stream.h:24,
                 from /userver-develop/grpc/include/userver/ugrpc/server/impl/async_methods.hpp:7,
                 from /userver-develop/grpc/src/ugrpc/server/impl/async_methods.cpp:1:
/toolchain/usr/include/absl/log/log.h:210:9: note: this is the location of the previous definition
  210 | #define LOG(severity) ABSL_LOG_INTERNAL_LOG_IMPL(_##severity)
Anton3 commented 9 hours ago

It seems that grpc has fixed the issue in newer versions.