search

userver-framework / userver

Production-ready C++ Asynchronous Framework with rich functionality
https://userver.tech
Apache License 2.0
2.45k stars 289 forks source link

[757] https tls cert chains #758

Open aklyuchev opened 2 weeks ago

aklyuchev commented 2 weeks ago

Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.

fdr400 commented 1 week ago

It it possible to add tests for it?

aklyuchev commented 1 week ago

It it possible to add tests for it?

tests for what? for openssl function which is used here? i don't think it make sense

apolukhin commented 1 week ago

It it possible to add tests for it?

tests for what? for openssl function which is used here? i don't think it make sense

It makes sense from the point of documentation. OpenSSL is overcomplicated, especially for the beginners. A test with some hints on how to create tls chains and how the file is named would be helpful. It also makes sense as a smoke test - the openssl function may require some other functions to be called before setting the chain... a test would prevent breaking the functionality during refactorings.

Please, add a smoke test to https://github.com/userver-framework/userver/blob/develop/core/src/engine/io/tls_wrapper_test.cpp