search

uservoice / uservoice-android-sdk

UserVoice Android SDK
https://www.uservoice.com/mobile/
MIT License
116 stars 105 forks source link

AndroidHttpClient is deprecated as of API 22 #181

Open phileo opened 9 years ago

phileo commented 9 years ago

According to the relevant developer webpage, Android's version of the Apache Http Client may be removed in the future.

Can userVoice switch to another HTTP client like OkHttp ?

austintaylor commented 9 years ago

We will probably switch to just java.net.URLConnection. I'm not sure how much effort this will be.

rothschild86 commented 9 years ago

sdk 23 has officially wiped out AndroidHttpClient... sdk 23 is required for appCompat v23, which has some crucial bug fixes. No choice but to pull uservoice from the project for the time being in order to use appCompat v23...

austintaylor commented 9 years ago

I now have the SDK working with OkHttp. Does this work for you? ace5c9ea62

rothschild86 commented 9 years ago

Very nice :)

Launched clean.

Then did user identification.

On the next launch got an npe on UV start.

Third launch was ok again.

Still keeping UV out of production because of this one https://github.com/uservoice/uservoice-android-sdk/issues/199

Attempt to invoke virtual method 'org.json.JSONObject org.json.JSONObject.getJSONObject(java.lang.String)' on a null object reference Attempt to invoke virtual method 'org.json.JSONObject org.json.JSONObject.getJSONObject(java.lang.String)' on a null object reference [com.uservoice.uservoicesdk.rest.RestResult.getType(RestResult.java:49), com.uservoice.uservoicesdk.flow.InitManager$2$1.onError(InitManager.java:68), com.uservoice.uservoicesdk.rest.RestTaskCallback.onError(RestTaskCallback.java:17), com.uservoice.uservoicesdk.rest.RestTask.onPostExecute(RestTask.java:98), com.uservoice.uservoicesdk.rest.RestTask.onPostExecute(RestTask.java:1), android.os.AsyncTask.finish(AsyncTask.java:632), android.os.AsyncTask.access$600(AsyncTask.java:177), android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:645), android.os.Handler.dispatchMessage(Handler.java:102), android.os.Looper.loop(Looper.java:136), android.app.ActivityThread.main(ActivityThread.java:5057), java.lang.reflect.Method.invoke(Native Method), com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786), com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)]

rothschild86 commented 9 years ago

Take note that OkHttp minSdk is 9, which raises UV min sdk as well.

thuytrinh commented 8 years ago

Nice, when will this be released?