Closed jurgenvinju closed 1 year ago
Good idea, I would like to get a fix in for #263 where the commands are not working correctly if in an embedded mode.
Has that issue been reproduced?
I think I know what's going wrong there, I need to find some time to get to it. But maybe that's better for a 0.8.1 release, as I don't think I'll get to it this week.
I'm pretty sure I won't make the release this week. It would be a miracle.
I want to propose we do not release vscode with -RC
dependencies in rascal-lsp. What's your opinion on that?
My feeling is, RC is nice for testing out integrations, but before we do an actual public release, we should make sure our dependencies are also non RC, since we tested out their integration.
O you mean inside! Yes indeed, like you said; we want to have the bootstrap complete. But to get that, we first need to test with RC dependencies, otherwise every new bug will have to lead to 2 new releases (one RC and one not) of the rascal project, or the vallang project, or both. That's just too much for my brain. Every RC release of Rascal also has to be "bootstrapped out" of rascal-maven-plugin before we release the lsp and the eclipse versions.
Then maybe they shouldn't be called RCs? Since RC normally signals: don't take dependencies on this, this is for integration testing, once we agree everything in these RCs is working as intended, we'll release a actual version.
are we not integration testing? I'm confused now.
We are :) I thought you meant that switching to non-RC would be to hard to do right before we actually release this VS Code 0.8.0. Otherwise I didn't understand your comment correctly.
To clarify, while these tests are running, I think RCs are the best approach. Once we agree it's all good, then we move to non-RC.
No that is not hard. It would be hard to switch during integration testing, because then we'd get a complex yoyo effect.
ah yes, that would be madness ;)
This is done. Currently running releases of all the libraries that will end up on rascal-mpl.org/doc/Packages
Preliminaries
Pre-releasing dependent tools in unstable
First a "pre-release" of the supporting compiler/typechecker tools must be done, so we know we are releasing a consistently compiled standard library.
Manual version checks
Manual feature tests
The list below was copied from the rascal-eclipse release; have to adapt while we go:
Required-Libraries: |lib://rascal-lsp|
rascal>1 + 1
on the REPLimport IO; println("Hello Rascal!");
RASCAL.MF
:Require-Libraries: |lib://otherProject|
, import a module and test the type-checker as well as the interpreter for correct resolution, also test a new REPL and import a library modules from the imported library.import demo::lang::pico::LanguageServer;
anddemo::lang::pico::LanguageServer::main();
and test the editor of some example pico files::edit demo::lang::pico::LanguageServer
#151Actual release
rascal-lsp/pom.xml
(in most cases, remove `-SNAPSHOT)rascal-vscode-extension/package.json
(in most cases by removing-head
from the current version)git commit -am "[release] set release version"
git tag vNewVersion
git tag rascal-lsp-NewVersion
(fill the rascal-lsp version that is released here, so for example rascal-lsp-2.12.0)head
suffix; e.g.0.2.0-head
snapshot
suffix; e.g.2.2.0-SNAPSHOT
git commit -am "[release] prepare for next release
git push
git push --tags