usethesource / rascal-language-servers

An LSP server for Rascal which includes an easy-to-use LSP generator for languages implemented in Rascal, and an interactive terminal REPL.
BSD 2-Clause "Simplified" License
10 stars 7 forks source link

Do a preliminary check for rascal project setup when starting a REPL #333

Closed DavyLandman closed 9 months ago

DavyLandman commented 9 months ago

This fixes #330.

You would get a message like this if you start a REPL without having a RASCAL.MF file in the correct location:

image

DavyLandman commented 9 months ago

We can also make these errors non-modal: image

but not sure if that might be too subtle.

(you can expand it for more details: image )

jurgenvinju commented 9 months ago

BTW, the "Takeout" project also has the problem of a capital T in its name. Do we check for this too?

DavyLandman commented 9 months ago

BTW, the "Takeout" project also has the problem of a capital T in its name. Do we check for this too?

our rascal.mf validator does. but that was missing at the moment :)

DavyLandman commented 9 months ago

It's a trade-off, should we try and make a full (in rascal) checker and fixer of project setups, or just detect most frequent errors, and point to the right way to construct a project?

I'm all in favor of making a nicer experience for our users, but we don't have to do that all at once.

jurgenvinju commented 9 months ago

It's a trade-off, should we try and make a full (in rascal) checker and fixer of project setups, or just detect most frequent errors, and point to the right way to construct a project?

Definitely we should not try and make a full rascal project fixer and checker. There is no bandwidth for that. We should keep doing what you've been doing: making essential improvements.

DavyLandman commented 9 months ago

@jurgenvinju agreed.

I've added a button so you can open the relevant documentation on our site, just to help users on the way to do it. and we can think about a proper way to fix the project setups later on.

could you review the messages?

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information