Closed DavyLandman closed 3 months ago
Will this PR make syntax highlighting Rascal code itself better/different? (like numbers in Rascal code will now be distinct?)
Will this PR make syntax highlighting Rascal code itself better/different? (like numbers in Rascal code will now be distinct?)
Yes, they will now be highlighted (since before they were just the regular text color). But it requires some further tuning to get a difference between the string literals and the numeric literals.
I want to merge this, but the windows runner is crashing on something weird. same case for main branch.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
The original implementation was half working, due to an incorrect interpretation of the standard. This commits fixes that. For backwards compatibility: it still supports the legacy ones from rascal and also the wrong text-mate ones.
The rendering of Rascal is the same, except that string and numeric literals are now both highlighted as string (where before they were not highlighted). This is something we can only fix in the rascal grammar.
Also, side-effect, the list of tokens send to the client is less, as we only try and send those that have an
category
and not all the plain ones.Fixes #366
TODO: