DavyLandman commented 1 month ago

Is your feature request related to a problem? Please describe. I want to have rename refactoring work for rascal.

When I as a user trigger rename on:

function
variable
module name

I want rascal to calculate the correct rename operation based on whats currently open in the workspace.

Describe the solution you'd like LSP has a dedicated api for rename. To pace our development, I would like to have support for rename first, and to the generic refactorings in a later stage. Similarly, if needed, we can split the support for rascal vs the support for DSLs.

Ideally the rename command is executed in a similar way as outline is done, we have rascal code that is invoked by the rascal-lsp server.

Describe alternatives you've considered

write the refactoring in Java: would be a bad idea, will be quite verbose
create a generic refactoring framework that models any refactoring of LSP to rascal, such that we can leverage that: too much work as an initial addition. First get rename right, use that implementation to learn how to do the rest.

Additional context Good news is that we already have TextEdits in Rascal, which map cleanly on the edits that LSP needs.

jurgenvinju commented 1 month ago

Textedits also cover file renamings, so that's cool if we change a module name

jurgenvinju commented 1 month ago

It would be best if we can reuse information generated by the type-checker; for example the summaries, collect them for all modules in a project and then reverse the references.

I would limit the current functionality to within a current project and push cross project uses/renamings to an enhancement issue. We don't even have cross-project incremental type-checking

toinehartman commented 1 month ago

Thanks for the directions! I set up all the boilerplate today and was just looking into (re)using type checker information and collecting across all modules. @DavyLandman and I will discuss tomorrow.

toinehartman commented 3 weeks ago

Feature milestones

Milestone 1 [boilerplate] (#389)

[x] Testing framework
[x] Support for renaming local variables

Milestone 2 [locals] (#389)

[x] Nested function names
[x] Formal parameters
[x] Pattern variables

Milestone 3 [globals]

[ ] Global variables
[ ] Functions (private)
[ ] Functions (public)
[ ] Aliases

Milestone 4 [modules]

[ ] Module names

Milestone 5 [grammars]

[ ] Symbols
[ ] Productions
[ ] Production fields

usethesource / rascal-language-servers

Offer rename refactoring of rascal identifiers #382

Feature milestones