search

usethesource / rascal-maven-plugin

The Maven plugin for Rascal checking, compilation, testing, code generation applications integration and documentation generation.
2 stars 2 forks source link

Errors reported with the wrong module names using rascal-core 0.8.7-BOOT1 #17

Closed jurgenvinju closed 5 months ago

jurgenvinju commented 5 months ago

This is running the plugin on the rascal project with rascal-core-0.8.7-BOOT1. Almost all errors are reported with the wrong module names. This could be caused by rascal-core but also by the maven-plugin itself (as its doing parallel runs):

[INFO] Warnings and errors for analysis/grammars/Brackets.rsc
[ERROR]   analysis/graphs/Graph.rsc:115:011: Return expression does not bind &T in return type
[ERROR]   lang/rascal/grammar/definition/Priorities.rsc:197:013: Return type `rel[Production, int, Production]` expected, found `rel[Production, int, &A]`
[ERROR]   lang/rascal/grammar/definition/Priorities.rsc:199:013: Return type `rel[Production, int, Production]` expected, found `rel[Production, int, &A]`
[ERROR]   lang/rascal/grammar/definition/Priorities.rsc:201:013: Return type `rel[Production, int, Production]` expected, found `rel[Production, int, &A]`
[ERROR]   lang/rascal/grammar/definition/Priorities.rsc:203:013: Return type `rel[Production, int, Production]` expected, found `rel[Production, int, &A]`
[ERROR]   lang/rascal/grammar/definition/Priorities.rsc:206:013: Return type `rel[Production, int, Production]` expected, found `rel[Production, int, &A]`
[ERROR]   lang/rascal/grammar/definition/Priorities.rsc:208:013: Return type `rel[Production, int, Production]` expected, found `rel[Production, int, &A]`
[ERROR]   lang/rascal/grammar/definition/Priorities.rsc:211:013: Return type `rel[Production, int, Production]` expected, found `rel[Production, int, &A]`
[ERROR]   lang/rascal/grammar/definition/Priorities.rsc:213:013: Return type `rel[Production, int, Production]` expected, found `rel[Production, int, &A]`
[ERROR]   lang/rascal/grammar/definition/Priorities.rsc:215:013: Return type `rel[Production, int, Production]` expected, found `rel[Production, int, &A]`
[INFO] Warnings and errors for analysis/grammars/Dependency.rsc
[ERROR]   analysis/graphs/Graph.rsc:115:011: Return expression does not bind &T in return type
[INFO] Warnings and errors for lang/rascal/format/Grammar.rsc
[ERROR]   analysis/graphs/Graph.rsc:115:011: Return expression does not bind &T in return type
[INFO] Warnings and errors for lang/rascal/grammar/definition/Productions.rsc
[WARNING] lang/rascal/grammar/definition/Productions.rsc:056:086: Annotations are deprecated, use keyword parameters instead
[INFO] Warnings and errors for analysis/graphs/LabeledGraph.rsc
[ERROR]   analysis/graphs/Graph.rsc:115:011: Return expression does not bind &T in return type
[INFO] Warnings and errors for analysis/text/search/Grammars.rsc
[WARNING] analysis/text/search/Grammars.rsc:017:029: Annotations are deprecated, use keyword parameters instead
[WARNING] analysis/text/search/Grammars.rsc:027:029: Annotations are deprecated, use keyword parameters instead
[WARNING] analysis/text/search/Grammars.rsc:037:031: Annotations are deprecated, use keyword parameters instead
[INFO] Warnings and errors for analysis/m3/Registry.rsc
[ERROR]   analysis/graphs/Graph.rsc:115:011: Return expression does not bind &T in return type
[INFO] Warnings and errors for lang/rascal/grammar/definition/References.rsc
[INFO]    lang/rascal/grammar/definition/References.rsc:016:038: Pattern variable `name` has been declared outside pattern and its value will be used, add explicit declaration here if you want a new variable
jurgenvinju commented 5 months ago

@PaulKlint this is not necessarily a bug from rascal-core. But could it be? Then I'll start looking there because we have changed this grouping feature recently there. It could just as well be a bug in the maven plugin; so if it's not rascal-core I'll start looking there.

jurgenvinju commented 5 months ago

The printing process is single threaded, so it can't be that.

DavyLandman commented 5 months ago

If you ever want to make sure, you can turn of parallel processing in the client-side. as parallel type checking is opt-in.

just comment out the <parallel>true</parallel> section of the pom.xml for rascal.

PaulKlint commented 5 months ago

Looks like errors related to our ongoing discussion howto check function declarations with type parameters.

jurgenvinju commented 5 months ago

This has been diagnosed as an issue in usethesource/rascal-core