Closed jurgenvinju closed 4 months ago
In RascalJunitTestRunner this code looks suspicious:
@Override
public void run(final RunNotifier notifier) {
if (desc == null) {
desc = getDescription();
}
notifier.fireTestRunStarted(desc);
for (Description mod : desc.getChildren()) {
if (mod.getAnnotations().stream().anyMatch(t -> t instanceof CompilationFailed)) {
notifier.fireTestFailure(new Failure(desc, new IllegalArgumentException(mod.getDisplayName() + " had importing errors")));
continue;
}
Listener listener = new Listener(notifier, mod);
TestEvaluator runner = new TestEvaluator(evaluator, listener);
runner.test(mod.getDisplayName());
}
notifier.fireTestRunFinished(new Result());
}
In particular we are not supposed to call notifier.fireTestRunFinished
or notifier.fireTestRunStarted
per the JUNit Javadoc on those methods. This is not necessarily the cause of this bug, but it might be.
Here is the bug in action: https://github.com/usethesource/clair/actions/runs/5132131642/jobs/9233036834
Describe the bug
So
BUILD SUCCESS
is a problem, so isTests run:0
and so isFailures: 0