Open jurgenvinju opened 2 weeks ago
Attention: Patch coverage is 11.90476%
with 37 lines
in your changes missing coverage. Please review.
Project coverage is 49%. Comparing base (
415773f
) to head (e964a65
). Report is 20 commits behind head on feat/error-recovery.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR now also covers has
, is
, setLabeledField
on error trees next to the getLabeledField
it was originally for.
This experiment makes parse tree instances (ITree's in Java) which happen to have error productions robust again field projection (in the interpreter)
Of course further field projection on such a stub would not work anymore, because there is no more production to work with. So this gives only one layer of robustness. A future version of this could recursively keep returning empty error stubs, but I don't know how to obtain the right type for those trees from the interpreter.
The questions are:
hasError
checks?At the very least field projection should work for fields which are before the dot. The rest is open for discussion I think.