search

usethesource / rascal

The implementation of the Rascal meta-programming language (including interpreter, type checker, parser generator, compiler and JVM based run-time system)
http://www.rascal-mpl.org
Other
407 stars 77 forks source link

Feat/remove auto disambiguation #2075

Open PieterOlivier opened 1 week ago

PieterOlivier commented 1 week ago

This PR removes the automatic disambiguation of error trees when allowRecovery=true but allowAmbiguity=false.

Note that in this case a separate check is needed for 'regular' ambiguities (which are not allowed).

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 49%. Comparing base (415773f) to head (40b1226).

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/ErrorRecovery.java 40% 6 Missing and 6 partials :warning:
...rc/org/rascalmpl/semantics/dynamic/Expression.java 0% 2 Missing :warning:
...g/rascalmpl/values/RascalFunctionValueFactory.java 0% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/error-recovery #2075 +/- ## ===================================================== Coverage 49% 49% - Complexity 6605 6607 +2 ===================================================== Files 685 685 Lines 61148 61152 +4 Branches 8850 8852 +2 ===================================================== + Hits 30239 30244 +5 + Misses 28706 28701 -5 - Partials 2203 2207 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.