usevital / notessential

The Nuxt-based frontend that powers NotEssential.
https://notessential.blurry.gay
GNU General Public License v3.0
13 stars 7 forks source link

Fix language names for Ukrainian & Russian #45

Closed cutiegin closed 1 month ago

cutiegin commented 1 month ago

Pull request template

Category

Describe changes

“Changed the name of the Ukrainian language from ‘Українець’ to ‘Українська’, and changed ‘русский’ to ‘Русский’ because the name of the language starts with an uppercase letter.

Why did you do this?

The word “Українець” translates to “Ukrainian” in English. It refers to a Ukrainian person, a citizen of Ukraine. This noun is used to describe nationality.

BREAKING CHANGES

What issues (if any) would this resolve?

Correct language name: Changing “Українець” to “Українська” corrects the mistake, as “Українець” means “Ukrainian” (a person), while “Українська” is the correct name for the Ukrainian language. Proper capitalization: Changing “русский” to “Русский” corrects the capitalization, as language names should start with an uppercase letter. These changes ensure accuracy and adherence to the standard conventions for writing language names.

Any extra notes?

Checklist

Vercel will begin deploying to the Preview environment shortly after submitting this pull request. You may click on the "Visit Preview" link below to see a preview of what your changes look like. If you updated only part of the repository such that it would not modify the website at all, you do not need to see the Vercel deployment.

You may also use the StackBlitz Codeflow button to quickview the PR in the browser and make changes at the same time if necessary.

stackblitz[bot] commented 1 month ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

vercel[bot] commented 1 month ago

@cutiegin is attempting to deploy a commit to the nugit's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notessential ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 3:14pm
blryface commented 1 month ago

lgtm ig I can't read either languages