usevital / notessential

The Nuxt-based frontend that powers NotEssential.
https://notessential.blurry.gay
GNU General Public License v3.0
13 stars 7 forks source link

Text that don't have entries in their respective lang JSONs don't show any text. #46

Closed KTrain5169 closed 1 month ago

KTrain5169 commented 1 month ago

Describe the bug here

(Issue raised by @Nitrrine) My description skills are absolutely insane (at being terrible) so I'll just go with an example here. Example: A new mod gets added to /alternatives

Steps to reproduce

Step 1: Visit the /experiments page Step 2: Select a language that doesn't have an entry for a specific mod (Snapper is the perfect test subject when this is written, as it only has an entry for en-US) Step 3: Visit /alternatives Step 4: Scroll until you see Snapper and note that it has no description.

Expected result

Fallback text from the en-US JSON is displayed

Additional info

Don't think any additional info is needed.

Example images

image

Checklist

worldwidepixel commented 1 month ago

Sort of surprised that fallbacks didn't kick in. I wonder if the lack of the translation entry on all other languages caused this?

KTrain5169 commented 1 month ago

Most likely. Usually the fallback text is an actual entry in the JSONs, but since new entries aren't immediately present in Crowdin there is no translation entry

worldwidepixel commented 1 month ago

We really need this crowdin connection

blryface commented 1 month ago

legit just gonna make an org called not essential and invite you guys

KTrain5169 commented 1 month ago

legit just gonna make an org called not essential and invite you guys

you are the owner of the crowdin = you still have to do it anyways

KTrain5169 commented 1 month ago

Fixed? by letting the Action just paste the source strings into the entries if there is no translation.