Add undo/redo - Githubissues

usewaypoint / email-builder-js

A free and open-source block-based email template builder.

https://emailbuilderjs.com

MIT License

470 stars 168 forks source link

Add undo/redo #129

Open amir9480 opened 1 month ago

amir9480 commented 1 month ago

There is one limitation that I couldn't fix. after undo/redo, values in the inspect tab are not updating.

jordanisip commented 1 month ago

Fantastic work, @amir9480. Appreciate the contribution. I'll leave the actual code review to @cohitre but a couple quick notes from my end:

~~I believe we can use the 'metaKey' keyboard event so it works for the different modifiers on mac vs pc.~~ (Edit: it sounds like metaKey actually maps to the windows key on PC so maybe we'd need (event.ctrlKey || event.metaKey) to support cross-platform keyboard shortcuts?
It appears the first block that gets added doesn't activate the undo. I would have expected to undo back to the empty state in this case:

CleanShot 2024-08-13 at 14 27 10@2x