usfm-bible / tcdocs

Technical Committee Documents
Other
9 stars 9 forks source link

Confusing documentation of attributes #71

Closed chrisvire closed 4 months ago

chrisvire commented 5 months ago

Comparing the documentation for \fig in 3.0: https://ubsicap.github.io/usfm/characters/index.html#fig-fig

to the new documentation for \fig: https://docs.usfm.bible/usfm-usx-docs/latest/fig/fig.html

  1. The new documentation has confusing @attribute stuff. For someone new to USFM, what are they supposed to do?

image

  1. There is no explanation about required vs. optional attributes. In the old documentation, there was a statement:

Required attributes are indicated in the list below with a red asterisk *.

This is missing from the new documentation. There are asterisks after the attribute names, but no explanation that it means they are required. I actually missed the fact that they were there until someone pointed them out.

chrisvire commented 5 months ago

Any comments?

KentSpiel commented 5 months ago

I think the content | @attr syntax should me mentioned here: https://docs.usfm.bible/usfm-usx-docs/latest/char/attributes.html along with how required and optional attributes are marked. I also suggest that we put an asterisk after the required attrs and add the line: Required attributes are indicated with an asterisk *.

Syntax

Required attributes are indicated with an asterisk *.

  • USFM: \fig caption|@src* @size* @ref* @alt @loc @copy\fig*

  • USX: <figure style="fig" @file* @size* @ref* @alt @loc @copy>caption</figure>

src (USFM) / file (USX)

Filename

size*

Illustration relative size. Options are col (illustration should be inserted inline within the current text column) or span (illustration should be inserted across – 'spanning' – text columns).

ref*

Scripture reference (e.g. Luke 19.5). This text may (optionally) be published together with the illustration caption.

alt

Short, free-form description of image.

. . . .

klassenjm commented 5 months ago

@chrisvire Thanks for reviewing and comparing the documentation (old and new), and sharing this feedback. I've been working on the new documents -- endeavoring to harmonize the USFM, USX, and USJ (at least USJ examples). It's been slow to get to completion recently -- just due to other work. I can take your feedback and Kent's suggestions (thanks @KentSpiel) and work at some improvements. I understand your points, and I'll try to get back to this soon.

klassenjm commented 4 months ago

Updates: