search

usgo / agagd

American Go Association Games Database (AGAGD)
https://agagd.usgo.org
MIT License
47 stars 30 forks source link

Update Beta Index #172

Closed michaelhiiva closed 3 years ago

michaelhiiva commented 3 years ago

Summary

Updated the beta index with redesigned theme.

Notes (Edited)

duckpunch commented 3 years ago

I guess one topic for discussion would be what we hope the state of the world will be after /beta becomes /. I assumed that issue #34 would be resolved by then, but it seems you might have had a different idea. What were your thoughts?

michaelhiiva commented 3 years ago

I guess one topic for discussion would be what we hope the state of the world will be after /beta becomes /. I assumed that issue #34 would be resolved by then, but it seems you might have had a different idea. What were your thoughts?

My thoughts are to avoid a rewrite of the logic or run custom outputs and queries if possible. If we can test the issue: https://github.com/usgo/agagd/issues/34#issue-22034647, that would be best. At this point there seem to be no examples of a case where we are seeing un-parsable Query Sets from chapters. I think it may be best if we can reproduce this problem before we move into something else.

Yes, either direction we go, issue #34 will be resolved.

Either better error handling or a different table framework?

I am probably taking the second part of https://github.com/usgo/agagd/issues/34#issue-22034647 at this point. Either way we seem to been needing to look into why we are getting un-parsable chapter sets, so we know that the issue is resolved.

michaelhiiva commented 3 years ago

Moving out of review, so to work on the comments.